[PATCH 4/9] ARM: imx: setup tctl register in device specific function
Shawn Guo
shawnguo at kernel.org
Tue May 19 01:08:09 PDT 2015
On Fri, May 15, 2015 at 10:35:51AM +0200, Arnd Bergmann wrote:
> On Friday 15 May 2015 16:11:42 shawnguo at kernel.org wrote:
> > }
> >
> > +static void imx1_gpt_setup_tctl(void)
> > +{
> > + u32 tctl_val;
> > +
> > + tctl_val = MX1_2_TCTL_FRR | MX1_2_TCTL_CLK_PCLK1 | MXC_TCTL_TEN;
> > + __raw_writel(tctl_val, imxtm.base + MXC_TCTL);
> > +}
> >
>
> Could you add another upfront patch to convert all the __raw_readl/__raw_writel
> to readl_relaxed/writel_relaxed?
>
> It would be nice if the driver was endian-safe by the time it gets moved to
> drivers/clocksource, and you don't add any unsafe accesses for the changed
> code.
Make sense. Will do.
Shawn
More information about the linux-arm-kernel
mailing list