[PATCH 11/12] ARM: migrate to common PSCI client code

Ashwin Chaugule ashwin.chaugule at linaro.org
Mon May 18 12:14:51 PDT 2015


On 18 May 2015 at 05:46, Mark Rutland <mark.rutland at arm.com> wrote:
>> >> +int psci_cpu_disable(unsigned int cpu)
>> >> +{
>> >> +       /* Fail early if we don't have CPU_OFF support */
>> >> +       if (!psci_ops.cpu_off)
>> >> +               return 0;
>> >> +
>> >> +       /* Trusted OS will deny CPU_OFF */
>> >> +       if (psci_tos_resident_on(cpu))
>> >> +               return 0;
>> >> +
>> >
>> > Same question here. Seems like if MIGRATE_INFO_TYPE = 2 ( TOS is
>> > present or does not require migration), you should be able to call
>> > CPU_OFF. Otherwise the patch looks fine to me.
>>
>> err. Make that TOS is not present.
>
> In the cases where migration is not required, resident_cpu == -1, and
> psci_tos_resident_on(cpu) will return false for any valid CPU. So I
> don't see that we would deny migration here.
>

Hm. Perhaps I was confused by the "return -EPERM" in the arm64 version
and "return 0" here. :)

Ashwin



More information about the linux-arm-kernel mailing list