[PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent

Thomas Gleixner tglx at linutronix.de
Fri May 15 13:29:50 PDT 2015


On Fri, 15 May 2015, Stefan Agner wrote:

> On 2015-05-15 12:39, Thomas Gleixner wrote:
> > On Sat, 9 May 2015, Stefan Agner wrote:
> >> -	irq_chip_unmask_parent(data);
> >> +	if (parent->chip->irq_enable)
> >> +		parent->chip->irq_enable(parent);
> >> +	else
> >> +		parent->chip->irq_unmask(parent);
> > 
> > Why are you not creating irq_chip_enable_parent() which would have
> > been the proper function anyway?
> > 
> 
> Will add that...
> 
> Btw, have you had a chance to look at 1/12? I added a helper there too

Yes 1/12 is fine ...



More information about the linux-arm-kernel mailing list