[PATCH v4 03/13] ARM: dts: exynos4: Use labels for overriding nodes in Exynos4210 Origen
Krzysztof Kozlowski
k.kozlowski.k at gmail.com
Wed May 13 02:55:59 PDT 2015
W dniu 13.05.2015 o 18:11, Kukjin Kim pisze:
> On 05/11/15 22:42, Krzysztof Kozlowski wrote:
>> Usage of labels instead of full paths reduces possible mistakes when
>> overriding nodes.
>>
>
> In case of this changes, I have no objection.
> But I can't see the 'codec' node you deleted in this patch?
It is under label "mfc". This label was already defined in exynos4.dtsi
before:
>> +&mfc {
>> + samsung,mfc-r = <0x43000000 0x800000>;
>> + samsung,mfc-l = <0x51000000 0x800000>;
>> + status = "okay";
>> +};
>
> And if possible, can you please put the labels in alphabetically when
> you create this patch again? so that we could find the labels easily...
Yes, when I switched to the "label convention" I put them in
alphabetical order. However I did not re-order other (existing) nodes.
This makes some confusion but I wanted to limit the scope of this change
and do only one thing - switch to "label convention".
Do you want me to reorder alphabetically everything?
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list