[PATCH v2 3/4] mtd: mxc_nand: fix truncate of unaligned oob copying
u.kleine-koenig at pengutronix.de
Wed May 13 00:18:28 PDT 2015
On Wed, May 13, 2015 at 10:12:01AM +0300, Baruch Siach wrote:
> Hi Uwe,
> On Wed, May 13, 2015 at 09:01:40AM +0200, Uwe Kleine-König wrote:
> > On Wed, May 13, 2015 at 09:59:22AM +0300, Baruch Siach wrote:
> > > On Wed, May 13, 2015 at 08:47:34AM +0200, Uwe Kleine-König wrote:
> > > > On Wed, May 13, 2015 at 09:44:04AM +0300, Baruch Siach wrote:
> > > > > > I thought we could get rid of the memcpy32 variants. Where do we need
> > > > > > memcpy32_* where memcpy16 wouldn't work?
> > > > >
> > > > > memcpy16 should work, but would take twice as much IO/memory accesses. That
> > > > > would definitely affect performance, as this is the flash data read/write hot
> > > > > path. I didn't test, though.
> > > > >
> > > > > Are you sure we want to do that?
> > > > no, I'm not sure. But I think it's worth to test how much performance
> > > > degrades.
> > >
> > > That will have to wait a few weeks as I don't have the hardware handy at the
> > > moment.
> > In the hope the test will not be forgotten I consider it ok to take this
> > series without the test (with keeping the memcpy32 that is).
> I'll respin this series with the ecc_8bit_layout name change as you suggested.
> May I have your Reviewed-by/Acked-by for the patches you are not the author
Sure, you can add an Acked-by for patches 2 and 3 for your resent. Note
that I prefer to have spaces around operators, too. That shouldn't be a
show stopper though.
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel