[PATCH v2 3/4] mtd: mxc_nand: fix truncate of unaligned oob copying

[Uwe Kleine-König]

On Wed, May 13, 2015 at 09:59:22AM +0300, Baruch Siach wrote:
> Hi Uwe,
> 
> On Wed, May 13, 2015 at 08:47:34AM +0200, Uwe Kleine-König wrote:
> > On Wed, May 13, 2015 at 09:44:04AM +0300, Baruch Siach wrote:
> > > > I thought we could get rid of the memcpy32 variants. Where do we need
> > > > memcpy32_* where memcpy16 wouldn't work?
> > > 
> > > memcpy16 should work, but would take twice as much IO/memory accesses. That 
> > > would definitely affect performance, as this is the flash data read/write hot 
> > > path. I didn't test, though.
> > > 
> > > Are you sure we want to do that?
> > no, I'm not sure. But I think it's worth to test how much performance
> > degrades.
> 
> That will have to wait a few weeks as I don't have the hardware handy at the 
> moment.
In the hope the test will not be forgotten I consider it ok to take this
series without the test (with keeping the memcpy32 that is).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |