[GIT PULL] SoCFPGA updates for v4.2
Dinh Nguyen
dinguyen at opensource.altera.com
Tue May 12 13:26:31 PDT 2015
On 05/12/2015 03:20 PM, Arnd Bergmann wrote:
> On Monday 11 May 2015 14:12:09 dinguyen at opensource.altera.com wrote:
>> SoCFPGA updates for v4.2
>> - Add big endian support
>> - Add earlyprintk support on UART1 that is used on Arria10
>> - Remove the need to map uart_io_desc
>>
>
> The patches look almost ok, but please clarify a minor issue:
>
> static void __init socfpga_map_io(void)
> {
> socfpga_scu_map_io();
> - iotable_init(&uart_io_desc, 1);
> - early_printk("Early printk initialized\n");
> }
>
>
> You have a map_io() function here, which means that the debug_ll_io_init()
> function is not called. How does the debug_ll mapping get created then?
>
> If it's not, I think the best solution is to remove the socfpga_map_io()
> function entirely, and turn socfpga_scu_base_addr into a local variable
> in arch/arm/mach-socfpga/platsmp.c that gets set using of_iomap().
>
Yes, you're right! Thanks for catching that. Will send a patch for this.
Dinh
More information about the linux-arm-kernel
mailing list