[PATCH 1/1] gpio: omap: Fix PM runtime issue and remove most BANK_USED macros

Linus Walleij linus.walleij at linaro.org
Tue May 12 02:00:10 PDT 2015

On Tue, Apr 21, 2015 at 6:08 PM, Tony Lindgren <tony at atomide.com> wrote:

> Looks like omap_gpio_irq_type can return early at several places
> leaving a GPIO bank enabled without doing pm_runtime_put if wrong
> GPIO arguments are passed.
> Instead of adding more complicated BANK_USED macros, let's fix the
> issue properly. We can pass is_irq flag to omap_enable_gpio_module
> and omap_disble_gpio_module. And with that we can remove all the
> similar code elsewhere to get rid of most BANK_USED macros.
> Note that the reason for the BANK_USED macro is that we need to manage
> PM runtime on per GPIO bank basis. In the long run we want to move to
> using PM runtime counts for each GPIO line to determine if a GPIO
> bank is used. Once we have a solution for omap_enable_gpio_module
> and omap_disable_gpio_module, we can remove the remaining BANK_USED
> macros.
> Cc: Felipe Balbi <balbi at ti.com>
> Cc: Grygorii Strashko <grygorii.strashko at linaro.org>
> Cc: Javier Martinez Canillas <jmartinez at softcrates.net>
> Cc: Nishanth Menon <nm at ti.com>
> Signed-off-by: Tony Lindgren <tony at atomide.com>

There is so much discussion around this patch that I can't make
up my mind whether I should apply this or some subsequent inline
version of it.

Holding this off for now...

Linus Walleij

More information about the linux-arm-kernel mailing list