[PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic
Mark Rutland
mark.rutland at arm.com
Mon May 11 09:04:02 PDT 2015
Hi Lorenzo,
> /**
> * struct cpu_operations - Callback operations for hotplugging CPUs.
> *
> - * @name: Name of the property as appears in a devicetree cpu node's
> - * enable-method property.
> - * @cpu_init: Reads any data necessary for a specific enable-method from the
> - * devicetree, for a given cpu node and proposed logical id.
> + * @name: Name of the enable-method.
I'm not keen on dropping the DT portion from the name documentation,
given the name must be the DT enable-method string. I'd prefer to leave
the original comment, or something at least mentioning that the name is
a DT enable-method string.
Other than that, this patch looks fine to me, and I don't see issues
booting on a (DT) system, so:
Acked-by: Mark Rutland <mark.rutland at arm.com>
Tested-by: Mark Rutland <mark.rutland at arm.com> [DT]
Has this has been tested on an ACPI system?
Thanks,
Mark.
More information about the linux-arm-kernel
mailing list