[PATCH] imx: thermal: use CPU temperature grade info for thresholds

Fabio Estevam festevam at gmail.com
Mon May 11 05:26:47 PDT 2015


On Thu, Apr 30, 2015 at 1:02 PM, Tim Harvey <tharvey at gateworks.com> wrote:

> +               /* The maximum die temp is specified by the Temperature Grade */
> +               switch ((val >> 6) & 0x3) {
> +               case 0: /* Commercial (0 to 95C) */
> +                       data->temp_grade = "Commercial";
> +                       data->temp_critical = 95000;
> +                       break;
> +               case 1: /* Extended Commercial (-20 to 105C) */
> +                       data->temp_grade = "Extended Commercial";
> +                       data->temp_critical = 105000;
> +                       break;

Looks good, only a minor suggestion for consistency: could you please
change "Commercial" to "Consumer"?

This is the term that is referenced in the datasheet, so better keep
it consistent.

Thanks



More information about the linux-arm-kernel mailing list