[PATCH 05/12] arm64: psci: support unsigned return values

Lorenzo Pieralisi lorenzo.pieralisi at arm.com
Mon May 11 05:25:25 PDT 2015


On Fri, May 08, 2015 at 12:36:37PM +0100, Mark Rutland wrote:

[...]

> -static int psci_get_version(void)
> +static u32 psci_get_version(void)
>  {
> -	int err;
> -
> -	err = invoke_psci_fn(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0);
> -	return err;
> +	return invoke_psci_fn(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0);
>  }
>  
>  static int psci_cpu_suspend(struct psci_power_state state,
> @@ -295,23 +292,13 @@ static int __init psci_probe(void)
>  {
>  	int ver = psci_get_version();

Is there a reason to keep ver as an int ?

Other than that the patch looks fine.

Lorenzo



More information about the linux-arm-kernel mailing list