[PATCH] ARM: dts: Add syscon property to the MIPI phy in exynos5420

Javier Martinez Canillas javier at dowhile0.org
Fri May 8 09:38:53 PDT 2015


Hello Tomeu,

I'm adding Krzysztof to the cc list since he is queuing Exynos patches
for Kukjin so is aware of this patch as well.

On Fri, May 8, 2015 at 3:30 PM, Tomeu Vizoso <tomeu.vizoso at collabora.com> wrote:
> Since e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by
> adding support for PMU regmap") the syscon property is required in
> samsung,s5pv210-mipi-video-phy nodes, but this DTS hadn't been updated
> yet.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
> Cc: Sylwester Nawrocki <s.nawrocki at samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index f67b23f..72a56f1 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -541,6 +541,7 @@
>         mipi_phy: video-phy at 10040714 {
>                 compatible = "samsung,s5pv210-mipi-video-phy";
>                 reg = <0x10040714 12>;

Shouldn't you remove the reg property too? the commit you mention
removes that property from the DT binding so it shouldn't be there.

> +               syscon = <&pmu_system_controller>;
>                 #phy-cells = <1>;
>         };
>
> --
> 2.4.0
>

With that change the patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>

Best regards,
Javier



More information about the linux-arm-kernel mailing list