[PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked.

Maxime Coquelin maxime.coquelin at st.com
Tue Mar 31 08:33:23 PDT 2015

Hello Tejun,

On 03/31/2015 05:29 PM, Tejun Heo wrote:
> On Tue, Mar 31, 2015 at 08:35:09AM +0100, Peter Griffin wrote:
>> Currently the ahci_st driver will hang the system on probe, as the
>> st_configure_oob function does some register writes before the IP
>> is clocked. This patch moves the function call to after
>> ahci_platform_enable_resources (which enables the IP clock), and
>> resolves the hang.
>> Addtionally st_ahci_configure_oob should be called in the st_ahci_resume
>> function, so we also rectify that ensuring it is also called after
>> the IP clock has been enabled.
>> Signed-off-by: Peter Griffin <peter.griffin at linaro.org>
>> Acked-by: Lee Jones <lee.jones at linaro.org>
>> Acked-by: Maxime Coquelin <maxime.coquelin at st.com>
> How should this patch be routed?  Should I pick this up and apply to
> libata/for-4.1 or should it go together with the other patches?  If
> the latter, please feel free to add my acked-by.

I think you can pick patches 1 & 3.
I will apply patch 2 to STi DT branch.

> Thanks.

More information about the linux-arm-kernel mailing list