[PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
Peter Ujfalusi
peter.ujfalusi at ti.com
Tue Mar 31 07:47:25 PDT 2015
On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
>> + if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
>> + "dma-requests",
>> + &od->dma_requests)) {
>> + dev_info(&pdev->dev,
>> + "Missing dma-requests property, using %u.\n",
>> + OMAP_SDMA_REQUESTS);
>> + od->dma_requests = OMAP_SDMA_REQUESTS;
>> + }
>
> Are all OMAPs including OMAP1 being converted to DT? If not, don't
> introduce noisy printks for which a platform can't do anything about.
> Think about this please - if there's no of_node, then why complain
> about a missing OF property?
Yes, you are perfectly right on this. Will fix it up.
Thanks,
Péter
More information about the linux-arm-kernel
mailing list