[PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs.
Michael Turquette
mturquette at linaro.org
Mon Mar 30 18:21:18 PDT 2015
Quoting Sascha Hauer (2015-03-30 10:40:41)
> +static void mtk_pll_set_rate_regs(struct clk_hw *hw, u32 pcw,
> + int postdiv)
> +{
> + struct mtk_clk_pll *pll = to_mtk_clk_pll(hw);
> + u32 con1, pd, val;
> + int pll_en;
> +
> + /* set postdiv */
> + pd = readl(pll->pd_addr);
> + pd &= ~(0x7 << pll->data->pd_shift);
Hi Sascha,
I found a couple of magic numbers in here. Can we replace these with
some descriptive constant?
Regards,
Mike
More information about the linux-arm-kernel
mailing list