[PATCH/RFC] ARM: shmobile: r8a7791: Remove MSIOF address from device tree

Geert Uytterhoeven geert at linux-m68k.org
Mon Mar 30 02:23:02 PDT 2015


Hi Kaneko-san,

On Sun, Mar 29, 2015 at 3:22 PM, Yoshihiro Kaneko <ykaneko0929 at gmail.com> wrote:
> I'm wondering if you could find a moment to look over this patch.

In light of the discussion thread w.r.t. to the driver changes (I
don't recall you
replying, did I miss that?), I think the DTS changes for r8a779[01] are fine.
However, please also update the example (for r8a7791) in
Documentation/devicetree/bindings/spi/sh-msiof.txt.

Thanks!

> 2015-03-15 23:43 GMT+09:00 Yoshihiro Kaneko <ykaneko0929 at gmail.com>:
>> From: Ryo Kataoka <ryo.kataoka.wt at renesas.com>
>>
>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>
>> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt at renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929 at gmail.com>
>> ---
>>
>> This patch is based on devel branch of Simon Horman's renesas tree.
>>
>>  arch/arm/boot/dts/r8a7791.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
>> index 4696062..3e9f824 100644
>> --- a/arch/arm/boot/dts/r8a7791.dtsi
>> +++ b/arch/arm/boot/dts/r8a7791.dtsi
>> @@ -1288,7 +1288,7 @@
>>
>>         msiof0: spi at e6e20000 {
>>                 compatible = "renesas,msiof-r8a7791";
>> -               reg = <0 0xe6e20000 0 0x0064>, <0 0xe7e20000 0 0x0064>;
>> +               reg = <0 0xe6e20000 0 0x0064>;
>>                 interrupts = <0 156 IRQ_TYPE_LEVEL_HIGH>;
>>                 clocks = <&mstp0_clks R8A7791_CLK_MSIOF0>;
>>                 dmas = <&dmac0 0x51>, <&dmac0 0x52>;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list