[PATCH] pinmux: allow exlusive pin allocation among GPIO and peripheral funtions via flag strict in struct pinctrl_desc

Linus Walleij linus.walleij at linaro.org
Fri Mar 27 01:32:39 PDT 2015


On Thu, Mar 19, 2015 at 11:06 AM, Sonic Zhang <sonic.adi at gmail.com> wrote:

> Anyway, if you think doing the explicit check in both if() and else()
> clauses is better, I am fine to send a new patch.

I looked at it for half an hour and could not figure out if it was
wrong or right really, eventually maybe got it wrong, maybe right.

What is happening is that the code is getting so convoluted that I cannot
follow the program flow, which is a clear sign that refactoring is needed.

Either restructure, add comments or break our helper functions.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list