[PATCH 3/5] leds: syscon: instantiate from platform device

[Bjorn Andersson]

On Tue, Mar 3, 2015 at 10:32 AM, Linus Walleij <linus.walleij at linaro.org> wrote:
[..]
> +static int syscon_led_remove(struct platform_device *pdev)
>  {
> -       struct device_node *np;
> -
> -       for_each_of_allnodes(np) {
> -               struct platform_device *pdev;
> -               struct regmap *map;
> -               int ret;
> +       struct syscon_led *sled = platform_get_drvdata(pdev);
>
> -               if (!of_device_is_compatible(np, "syscon"))
> -                       continue;
> +       led_classdev_unregister(&sled->cdev);
> +       /* Turn it off */
> +       regmap_update_bits(sled->map, sled->offset, sled->mask, 0);

led_classdev_unregister() should have called your brightness_set op
already to disable the LED - see led-class.c line 279. So you
shouldn't need this.
I like the rest and have been missing "simple-mfd" in other use cases...

So part of the extra disable:
Reviewed-by: Bjorn Andersson <bjorn.andersson at sonymobile.com>

Regards,
Bjorn