[PATCH v3] input: Add support for ChipOne icn8318 based touchscreens

Dmitry Torokhov dmitry.torokhov at gmail.com
Sat Mar 21 21:03:05 PDT 2015


Hi Hans,

On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote:
> +	error = devm_request_threaded_irq(dev, client->irq, NULL, icn8318_irq,
> +					  IRQF_TRIGGER_FALLING | IRQF_ONESHOT,

Shouldn't we let DT data tell us what trigger to use? I.e. just leave
IRQF_ONESHOT here?

No need to resubmit, just let me know if you agree/disagree...

Thanks.

-- 
Dmitry



More information about the linux-arm-kernel mailing list