[UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
Mark Rutland
mark.rutland at arm.com
Thu Mar 19 10:32:52 PDT 2015
One more thing:
> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> pdev->dev.of_node);
> if (!match)
> return NULL;
> + if (match->data)
> + return match->data;
>
> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> + "requires secure access to CCI registers");
> return probe_cci_model(pdev);
> }
Before the probe, could we please have:
if (!IS_ENABLED(CONFIG_ARM))
return -EINVAL;
On arm64 we require a model-specific string, and we shouldn't go
touching secure-only registers.
Mark.
More information about the linux-arm-kernel
mailing list