[PATCH v5 8/8] arm64: enforce x1|x2|x3 == 0 upon kernel entry as per boot protocol
mark.rutland at arm.com
Wed Mar 18 11:57:37 PDT 2015
On Wed, Mar 18, 2015 at 06:46:11PM +0000, Ard Biesheuvel wrote:
> On 18 March 2015 at 19:16, Ard Biesheuvel <ard.biesheuvel at linaro.org> wrote:
> > On 18 March 2015 at 19:13, Mark Rutland <mark.rutland at arm.com> wrote:
> >> On Wed, Mar 18, 2015 at 02:55:27PM +0000, Ard Biesheuvel wrote:
> >>> According to the arm64 boot protocol, registers x1 to x3 should be
> >>> zero upon kernel entry, and non-zero values are reserved for future
> >>> use. This future use is going to be problematic if we never enforce
> >>> the current rules, so start enforcing them now, by emitting a warning
> >>> if non-zero values are detected.
> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> >>> ---
> >>> arch/arm64/kernel/head.S | 4 ++++
> >>> arch/arm64/kernel/setup.c | 15 +++++++++++++++
> >>> 2 files changed, 19 insertions(+)
> >>> diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S
> >>> index a0fbd99efb89..8636c3cef006 100644
> >>> --- a/arch/arm64/kernel/head.S
> >>> +++ b/arch/arm64/kernel/head.S
> >>> @@ -233,6 +233,10 @@ section_table:
> >>> #endif
> >>> ENTRY(stext)
> >>> + adr_l x8, boot_regs // record the contents of
> >>> + stp x0, x1, [x8] // x0 .. x3 at kernel entry
> >>> + stp x2, x3, [x8, #16]
> >> I think we should have a dc ivac here as we do for
> >> set_cpu_boot_mode_flag.
> >> That avoids a potential issue with boot_regs sharing a cacheline with
> >> data we write with the MMU on -- using __flush_dcache_area will result
> >> in a civac, so we could write back dirty data atop of the boot_regs if
> >> there were clean entries in the cache when we did the non-cacheable
> >> write.
> > Hmm, I wondered about that.
> > Could we instead just make it u64 __initconst boot_regs in setup.c ?
> Never mind, it's easier just to do the invalidate right after, and I
> can drop the flush before the access.
Annoyingly the minimum cache line size seems to be a word (given the
defnition of CTR.DminLine), which means you need a few dc ivac
instructions to be architecturally correct.
More information about the linux-arm-kernel