[PATCHv4 23/35] ARM: OMAP2+: id: cache omap_type value

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Wed Mar 18 11:24:32 PDT 2015


Hello.

On 03/18/2015 05:44 PM, Tero Kristo wrote:

> There is no need to read the register with every invocation of the function,
> as the value is constant. Thus, cache the value in a static variable.

> Signed-off-by: Tero Kristo <t-kristo at ti.com>
> ---
>   arch/arm/mach-omap2/id.c |    5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)

> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 2a2f4d5..1f5949f 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -52,7 +52,10 @@ EXPORT_SYMBOL(omap_rev);
>
>   int omap_type(void)
>   {
> -	u32 val = 0;
> +	static u32 val = OMAP2_DEVICETYPE_MASK + 1;
> +
> +	if (val < OMAP2_DEVICETYPE_MASK)

    <=, perhaps?

> +		return val;
[...]

WBR, Sergei




More information about the linux-arm-kernel mailing list