[PATCH] arm: crypto: Add NEON optimized SHA-256
ard.biesheuvel at linaro.org
Mon Mar 16 23:56:02 PDT 2015
On 16 March 2015 at 17:23, Sami Tolvanen <samitolvanen at google.com> wrote:
> On Mon, Mar 16, 2015 at 05:08:03PM +0100, Ard Biesheuvel wrote:
>> Have you tested this code with the tcrypt.ko module?
> I have not, but I can look into it.
>> Did you talk to Andy about the license? I don't think this is
>> permissible for the kernel as-is.
> Unless I have misunderstood something, the license at the Cryptogams
> website includes an option to license the code under the GNU GPL.
> However, I can certainly contact Andy to clarify his intentions.
>> This is broken on thumb-2, use adr instead
>> You can also implement SHA-224 using the same core transform, it's
>> just some trivial glue code.
>> Could you please rebase this onto Herbert's cryptodev tree and move
>> this to arch/arm/crypto/Kconfig?
> Thanks for the comments, I will submit a second version once we have
> a clarification on the license.
I have tested your code with a Thumb2 kernel. With this patch folded,
it builds and passes the tcrypt.ko test for me
@@ -10,7 +10,6 @@
@@ -44,15 +43,15 @@ ENTRY(sha256_transform_neon)
* %r1: data
* %r2: nblks
- sub r3,pc,#8 @ sha256_transform_neon
add r2,r1,r2,lsl#6 @ len to point at the end of inp
- sub sp,sp,#16*4+16 @ alloca
- sub r14,r3,#256+32 @ K256
- bic sp,sp,#15 @ align for 128-bit stores
+ sub r14,sp,#16*4+16 @ alloca
+ bic r14,r14,#15 @ align for 128-bit stores
+ mov sp,r14
+ adr r14,K256
More information about the linux-arm-kernel