[RFT/RFC PATCH 6/6] ARM: keep .text and .fixup regions together

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Mar 12 14:10:52 PDT 2015


On Thu, Mar 12, 2015 at 06:38:12PM +0100, Ard Biesheuvel wrote:
> Fixup snippets are put into a dedicated section so that they don't
> bloat cache lines with instructions that are usually not executed.
> But there is no reason to put all these snippets together at the far
> end of the .text output region, where the branch instruction they
> contain could go out of range if the kernel grows in size.
> 
> Instead, emit .text and .fixup regions together for each input object.
> They should still be out of the way, but not so far that they go out
> of range.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> 
> Note that the TEXT_TEXT macro will emit *(.text) again but this should be
> harmless.

However, I wonder if by doing this, we're weakening the ability for
kallsyms final link to succeed:

/* .text section. Map to function alignment to avoid address changes
 * during second ld run in second ld pass when generating System.map */

Can we not just move .fixup before TEXT_TEXT?  The only thing between it
and .text would be .text.hot.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list