[PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

Linus Walleij linus.walleij at linaro.org
Mon Mar 9 09:14:39 PDT 2015


On Sun, Feb 8, 2015 at 7:23 PM, Boris Brezillon
<boris.brezillon at free-electrons.com> wrote:

> The gpiochip_lock_as_irq call can fail and return an error, while the
> irq_startup is not expected to fail (returns an unsigned int which is not
> checked by irq core code).
>
> irq_request/release_resources functions have been created to address this
> problem.
>
> Move gpiochip_lock/unlock_as_irq calls into
> irq_request/release_resources functions to prevent using a gpio as an irq
> if the gpiochip_lock_as_irq call failed.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>

Patch applied with all the ACKs.

Happy new year J-C!

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list