[PATCH v3 1/9] ACPI: fix all errors reported by cleanpatch.pl in osl.c

Rafael J. Wysocki rjw at rjwysocki.net
Wed Mar 4 15:04:54 PST 2015

On Tuesday, February 24, 2015 05:36:17 PM al.stone at linaro.org wrote:
> From: Al Stone <al.stone at linaro.org>
> In preparation for later splitting out some of the arch-dependent code from
> osl.c, clean up the errors reported by checkpatch.pl.  They fell into these
> classes:
>    -- remove the FSF address from the GPL notice
>    -- "foo * bar" should be "foo *bar" (and the ** variation of same)
>    -- a return is not a function, so parentheses are not required.
> Signed-off-by: Al Stone <al.stone at linaro.org>

checkpatch.pl is irrelevant here.  You're trying to make the coding style be
more consistent with the coding style of the rest of the kernel.

The warnings from checkpatch.pl are meaningless for the existing code, so
it should not be used to justify changes in that code.

Of course, the same applies to patches [2-4/9].

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

More information about the linux-arm-kernel mailing list