[PATCH] ARM64: gic: Do not allow bypass FIQ signals to reach to processor

[Pratyush Anand]

On Tuesday 03 March 2015 02:46 PM, Marc Zyngier wrote:
> On 03/03/15 03:12, Pratyush Anand wrote:
>>
>> On Friday 13 February 2015 01:43 PM, Pratyush Anand wrote:
>>> Hi Jason,
>>>
>>> On Monday 09 February 2015 11:48 AM, Pratyush Anand wrote:
>>>> In some case few signals of an IP(like PMU Overflow in APM88xx0x) can be
>>>> mapped to nLEGACYFIQ, ie nFIQ of CPU. Until ARM64 supports FIQ handling,
>>>> we will get nice "Bad mode in FIQ handler detected"
>>>>
>>>> Therefore force FIQBypDisGrp1 to '1', so that bypass FIQ signal is not
>>>> signaled to the processor.
>>>>
>>>
>>> Please review this patch.
>>
>> ping
>>
>>>
>>> ~Pratyush
>>>
>>>> Signed-off-by: Pratyush Anand <panand at redhat.com>
>>>> ---
>>>>    drivers/irqchip/irq-gic.c       | 9 ++++++++-
>>>>    include/linux/irqchip/arm-gic.h | 1 +
>>>>    2 files changed, 9 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
>>>> index d617ee5a3d8a..525dfc966e60 100644
>>>> --- a/drivers/irqchip/irq-gic.c
>>>> +++ b/drivers/irqchip/irq-gic.c
>>>> @@ -362,7 +362,14 @@ static void gic_cpu_if_up(void)
>>>>        */
>>>>        bypass = readl(cpu_base + GIC_CPU_CTRL);
>>>>        bypass &= GICC_DIS_BYPASS_MASK;
>>>> -
>>>> +#ifdef CONFIG_ARM64
>>>> +    /* FIXME: when ARM64 starts supporting FIQ mode.
>>>> +     *
>>>> +     * Until ARM64 supports FIQ handling, force FIQBypDisGrp1 to
>>>> +     * '1', so that bypass FIQ signal is not signaled to the processor.
>>>> +     */
>>>> +    bypass |= GICC_DIS_BYPASS_FIQ_TO_CPU;
>>>> +#endif
>
> This doesn't feel like the right approach at all. We have a bypass mask
> already, for the same HW.
>
> But more importantly, FIQBypDisGrp0 is only available in secure mode,
> while the arm64 kernel only runs in non-secure. I understand that the
> APM HW doesn't have a secure mode, but the GIC definitely has.
>
> I suggest you move that change to your firmware, and make sure that the
> kernel is only presented the non-secure version of the CPU interface.
>

Thanks Marc for your input.

~Pratyush