[PATCH v2] crypto: atmel: fix bogus select

Herbert Xu herbert at gondor.apana.org.au
Mon Mar 2 02:25:13 PST 2015


On Thu, Feb 19, 2015 at 04:38:19PM +0100, Arnd Bergmann wrote:
> The Atmel at91 crypto driver unconditionally selects AT_HDMAC,
> which results in a Kconfig warning if that driver is not enabled:
> 
> warning: (CRYPTO_DEV_ATMEL_AES) selects AT_HDMAC which has unmet direct dependencies (DMADEVICES && ARCH_AT91)
> 
> The crypty driver itself does not actually have a dependency
> on a particular dma engine, other than this being the one that
> is used in at91.
> 
> Removing the 'select' gets rid of the warning, but can cause
> the driver to be unusable if the HDMAC is not enabled at the
> same time. To work around that, this patch clarifies the runtime
> dependency to be '(ARCH_AT91 && AT_XDMAC)', but adds an alternative
> for COMPILE_TEST, which lets the driver get build on all systems.
> 
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>

If this is meant to go through the crypto tree it needs to cc
linux-crypto at vger.kernel.org.  Otherwise please carry on :)
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list