[PATCH] clk: samsung: fix cpu clock's flags checking

Bartlomiej Zolnierkiewicz b.zolnierkie at samsung.com
Tue Jun 30 10:51:32 PDT 2015


On Tuesday, June 30, 2015 07:45:15 PM Javier Martinez Canillas wrote:
> Hello Bartlomiej,
> 
> On 06/30/2015 07:17 PM, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > On Tuesday, June 30, 2015 08:27:36 AM Javier Martinez Canillas wrote:
> >> On Tue, Jun 30, 2015 at 2:06 AM, Krzysztof Kozlowski
> >> <k.kozlowski at samsung.com> wrote:
> >> > On 30.06.2015 02:29, Bartlomiej Zolnierkiewicz wrote:
> >> >> CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were
> >> >> incorrectly used as a bit numbers.  Fix it.
> >> >>
> >> >> Tested on Exynos4210 based Origen board and on Exynos5250 based
> >> >> Arndale board.
> >> >>
> >> >> Cc: Tomasz Figa <tomasz.figa at gmail.com>
> >> >> Cc: Michael Turquette <mturquette at baylibre.com>
> >> >> Cc: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
> >> >> Cc: Thomas Abraham <thomas.ab at samsung.com>
> >> >> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> >> >> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> >> >> ---
> >> >>  drivers/clk/samsung/clk-cpu.c | 10 +++++-----
> >> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >> >
> >> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> >> >
> >> 
> >> Looks good to me as well.
> >> 
> >> Reviewed-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
> > 
> > Krzysztof has noted that I should use your @dowhile0.org e-mail address
> > instead of @collabora.co.uk one, is this right?
> >
> 
> I don't know what is the policy for tags but Krzysztof is correct that
> this email address is going away this week so for future patches please
> use my personal @dowhile0.org address instead.

OK, I'll update my patches & scripts then.

Thank you for review.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics




More information about the linux-arm-kernel mailing list