[PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap

Grygorii Strashko grygorii.strashko at ti.com
Tue Jun 30 03:44:22 PDT 2015

On some PAE systems (e.g. TI Keystone), memory is above the 32-bit
addressable limit, and the interconnect provides an aliased view of
parts of physical memory in the 32-bit addressable space. This alias
is strictly for boot time usage, and is not otherwise usable because
of coherency limitations.

On such systems, the idmap mechanism has to be used to pass correct
boot address of secondary CPU to FW.
virt_to_idmap() will fall-back to existing virt_to_phys() macro if
such conversation is not required.

Cc: Mark Rutland <mark.rutland at arm.com>
Cc: Nicolas Pitre <nico at linaro.org>
Cc: Santosh Shilimkar <ssantosh at kernel.org>
Cc: Vitaly Andrianov <vitalya at ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
 arch/arm/kernel/psci_smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c
index 28a1db4..244aadd 100644
--- a/arch/arm/kernel/psci_smp.c
+++ b/arch/arm/kernel/psci_smp.c
@@ -51,7 +51,7 @@ static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle)
 	if (psci_ops.cpu_on)
 		return psci_ops.cpu_on(cpu_logical_map(cpu),
-				       __pa(secondary_startup));
+					virt_to_idmap(&secondary_startup));
 	return -ENODEV;

More information about the linux-arm-kernel mailing list