[PATCH RFC v2 03/16] PM / Domains: Support IRQ safe PM domains

Geert Uytterhoeven geert at linux-m68k.org
Mon Jun 29 06:10:52 PDT 2015


Sorry, I forgot a few comments...

On Sat, Jun 27, 2015 at 5:02 AM, Lina Iyer <lina.iyer at linaro.org> wrote:
> --- a/Documentation/power/devices.txt
> +++ b/Documentation/power/devices.txt

> +context, may contain IRQ safe devices. Such domain may only contain only IRQ

Double "only".

> +safe devices or IRQ safe sub-domains.

> @@ -532,15 +608,18 @@ static int pm_genpd_runtime_resume(struct device *dev)
>         if (IS_ERR(genpd))
>                 return -EINVAL;
>
> -       /* If power.irq_safe, the PM domain is never powered off. */
> -       if (dev->power.irq_safe) {
> +       /*
> +        * As we dont power off a non IRQ safe domain, which holds a

Bogus "a" at the end.

> +        * an IRQ safe device, we dont need to restore power to it.
> +        */

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list