[PATCH 1/2] ARM: BCM: Do not select CONFIG_MTD_NAND_BRCMNAND

[Rafał Miłecki]

On 28 June 2015 at 01:01, Gregory Fong <gregory.0xf0 at gmail.com> wrote:
> On Sat, Jun 27, 2015 at 2:39 PM, Rafał Miłecki <zajec5 at gmail.com> wrote:
>> On 27 June 2015 at 18:25, Florian Fainelli <f.fainelli at gmail.com> wrote:
>>> This reverts 7dc95b40f599293aedf30432749ad25b51549041 ("ARM: BCM: Enable
>>> NAND support for iProc SoCs") since it creates an unmet dependency for
>>> MTD_NAND_BRCMNAND which depends on MTD and MTD_NAND, this results in the
>>> following build failure for brcmnand:
>>
>> This commit message doesn't make too much sense to me. If
>> MTD_NAND_BRCMNAND really depends on MTD and MTD_NAND then there
>> couldn't be this problem you described.
>>
>> Maybe MTD_NAND_BRCMNAND is *missing* that dependency?
>
> Per Documentation/kbuild/kconfig-language.txt: "select will force a
> symbol to a value without visiting the dependencies. By abusing select
> you are able to select a symbol FOO even if FOO depends on BAR that is
> not set."
>
> I believe this is what is happening here.

Oops, it seems I still don't know Kconfig well enough.

Thanks for explaining, sorry for the noise, it looks fine!

-- 
Rafał