[PATCH] ARM: BCM5301X: Enable UART0 for SmartRG SR-400AC

[Rafał Miłecki]

On 28 June 2015 at 03:38, Florian Fainelli <f.fainelli at gmail.com> wrote:
> Le 06/27/15 15:08, Rafał Miłecki a écrit :
>> On 24 June 2015 at 01:51, Florian Fainelli <f.fainelli at gmail.com> wrote:
>>> Enable the use of UART0 by overriding its default status property.
>>>
>>> Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>
>>> ---
>>>  arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>>> index d6a033b97c70..64a5e8ab65e0 100644
>>> --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>>> +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts
>>> @@ -118,3 +118,7 @@
>>>                 };
>>>         };
>>>  };
>>> +
>>> +&uart0 {
>>> +       status = "okay";
>>> +};
>>
>> We have many more changes like this in OpenWrt, I just didn't upstream
>> them because of current chipcommonA state.
>>
>> It was added before we got "brcm,bus-axi" and I believe Hauke wanted
>> move it to the "correct" place at some point. Since UART is part of
>> ChipCommon device and ChipCommon is part of "brcm,bus-axi",.I guess we
>> should add UARTs as a ChipCommon device subnodes. We already have
>> chipcommon: chipcommon at 0 {
>>         reg = <0x00000000 0x1000>;
>>
>>         gpio-controller;
>>         #gpio-cells = <2>;
>> };
>> , is it possible to move UARTs there?
>>
>> I'm not sure if this UART cleanup should block your change. I guess it
>> depends on the way it'll finally look like.
>
> I do not think it will, see below:

You answered about using &uart0 instead a whole path and it sounds OK.

What about moving this whole chipcommonA node into "chipcommon: chipcommon at 0"?
Hauke did you try that?

-- 
Rafał