[PATCH] keystone: psci: adds cpu_die implementation

Mark Rutland mark.rutland at arm.com
Fri Jun 26 09:59:29 PDT 2015


> OK. Now I'm confused :) We may have several different configurations here:
> 
> 1) CONFIG_HOTPLUG_CPU and CONFIG_ARM_PSCI are not set.
>     In this case keystone arch needs to have
>     keystone_smp_boot_secondary();
> 
> 2) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI is not set.
>     keystone_smp_boot_secondary() is required and non PSCI
>     implementation of keystone_cpu_die() is also required.
> 
> 3) CONFIG_HOTPLUG_CPU is not set and CONFIG_ARM_PSCI=y
> 4) CONFIG_HOTPLUG_CPU=y and CONFIG_ARM_PSCI=y
> 
>     How do I boot secondary CPUs in cases of 3 and 4?
>     Do I need to implement PSCI version of the
>     keystone_smp_boot_secondary() of adding PSCI commands to DTB is
>     enough?

The DTB additions alone _should_ be sufficient.

>     Do I need to implement keystone_cpu_die() if PSCI commands are
>     added to DTB?

You _should not_ need to add any platform code to use PSCI.

However, if you have existing platform code which pokes the hardware
logically owned by your FW PSCI implementation, you need to ensure that
this code doesn't poke that hardware when PSCI is in use.

Thanks,
Mark.



More information about the linux-arm-kernel mailing list