imx6 GPIO1 interrupts

[Uwe Kleine-König]

Hello,

probably not helpful for your original question, but ...

On Thu, Feb 19, 2015 at 10:09:40AM -0800, Joshua Clayton wrote:
> Freescale imx6 has gpios use shared irqs that trigger across 16 pins
> at a time. These are supported in the mainline kernel.
> 
> The first 8 pins on GPIO1 also have their own interrupts on the GIC.
> I have a kluge sort of working,  and am wondering what it would take
> for me to fully support these in a way that might be mainlined.
> 
> What I am doing:
> (error checking removed for brevity)
> 
>         /* request the shared gpio irq to set the correct edge bits */
>         gpiod = gpiod_get(my->dev, "diffirq");
>         ret = gpiod_direction_input(gpiod);
... you should make this read:

	gpiod = gpiod_get(my->dev, "diffirq", GPIOD_IN);

instead. It's easier and gpiod_get with only two parameters will go away
soon.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |