[linux-sunxi] Re: [PATCH] input: axp20x-pek: Fix reporting button state as inverted

[Dmitry Torokhov]

On Wed, Jun 24, 2015 at 11:19:39AM +0200, Carlo Caione wrote:
> On Wed, Jun 24, 2015 at 3:42 AM, Chen-Yu Tsai <wens at csie.org> wrote:
> > On Tue, Jun 23, 2015 at 5:30 AM, Dmitry Torokhov
> > <dmitry.torokhov at gmail.com> wrote:
> >> On Sun, Jun 14, 2015 at 12:42:21PM +0200, Hans de Goede wrote:
> >>> Currently we are reporting the button state as inverted on all boards with
> >>> an axp209 pmic, tested on a ba10-tvbox, bananapi, bananapro, cubietruck and
> >>> utoo-p66 tablet.
> >>>
> >>> The axp209 datasheet clearly states that the power button must be connected
> >>> between the PWRON key and ground. Which means that on a press we will get
> >>> a falling edge (dbf) irq not a rising one, and likewise on release we will
> >>> get a rising edge (dbr) irq, not a falling one.
> >>>
> >>> This commit swaps the check for the 2 irqs fixing the inverted reporting of
> >>> the power button state.
> >>>
> >>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> >>
> >> Carlo, Chen-Yu, could you please give this patch a spin and let us know
> >> if it works on your boards?
> >
> > I've not actually tested this patch on my boards, but I can confirm that
> > the original code had the state inverted, by checking /proc/interrupts
> > counters, before and after releasing the power button.
> >
> > Acked-by: Chen-Yu Tsai <wens at csie.org>
> 
> Same here (I don't have the board anymore)
> 
> Acked-by: Carlo Caione <carlo at caione.org>

Applied, thank you.

-- 
Dmitry