[PATCH v2 1/2] ARM: rockchip: add support holding 24Mhz osc during suspend
heiko at sntech.de
Mon Jun 22 14:01:24 PDT 2015
Am Montag, 22. Juni 2015, 13:04:02 schrieb Doug Anderson:
> On Sun, Jun 21, 2015 at 3:00 AM, Chris Zhong <zyw at rock-chips.com> wrote:
> > If we want to wake up system via usb, the 24Mhz osc could not be
> > disabled during suspend, read the usb phy SIDDQ bit to decide whether
> > to switch to 32khz clock-in.
> > Signed-off-by: Chris Zhong <zyw at rock-chips.com>
> > ---
> > arch/arm/mach-rockchip/pm.c | 38 ++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 36 insertions(+), 2 deletions(-)
> As talked about privately, this patch is ugly. ...but I don't see a
> solution that is less ugly. This method has the advantages that it is
> "automatic"--the system figures out whether it needs the 24MHz clock
> automatically based on whether the PHYs were left on. No other
> communication / device tree stuff is needed.
Yep, fully agreed :-) .
As I said before, another possible solution would probably involve checking
the phy clocks themselfs, but getting these out of the devicetree would make
this even more ugly.
So I'll let this sit for some more days in case somebody wants to complain
(middle of the merge window anyway) and apply these two after.
> > + /* if any usb phy is still on(GRF_SIDDQ==0), that means we need
> > the
> > + * function of usb wakeup, so do not switch to 32khz, since the
> > usb phy + * clk does not connect to 32khz osc*/
> This is not _quite_ the block commenting style used in this file. It
> would be a bit nicer if it matched.
> Other than that:
> Reviewed-by: Douglas Anderson <dianders at chromium.org>
> On the chromeos-3.14 kernel (with the WIP dwc2 patches):
> Tested-by: Douglas Anderson <dianders at chromium.org>
More information about the linux-arm-kernel