[PATCH] ARM: imx6: Fix "BUG: scheduling while atomic" if PCIe switch is attached
Lucas Stach
l.stach at pengutronix.de
Thu Jun 18 01:27:01 PDT 2015
Am Donnerstag, den 18.06.2015, 09:56 +0200 schrieb David Müller:
> This problem has already been reported as
> https://bugzilla.kernel.org/show_bug.cgi?id=100031
>
> Signed-off-by: David Müller <dave.mueller at gmx.ch>
> ---
> drivers/pci/host/pci-imx6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> index fdb9536..c63691c 100644
> --- a/drivers/pci/host/pci-imx6.c
> +++ b/drivers/pci/host/pci-imx6.c
> @@ -489,7 +489,7 @@ static int imx6_pcie_link_up(struct pcie_port *pp)
> * Wait a little bit, then re-check if the link finished
> * the training.
> */
> - usleep_range(1000, 2000);
> + mdelay(20);
While switching to mdelay might be the right thing to do here, you are
also changing the timeout. This is a change in behavior and so not okay.
Especially as you keep the CPU spinning for the duration of that
timeout.
> }
> /*
> * From L0, initiate MAC entry to gen2 if EP/RC supports gen2.
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list