[PATCH v7 05/14] crypto: marvell/CESA: add TDMA support

Herbert Xu herbert at gondor.apana.org.au
Wed Jun 17 08:08:08 PDT 2015


On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
>
> Hi Herbert,
> 
> I send you this patch alone so that you can verify I'm now properly
> manipulating the SG list. Once I have your confirmation I'll send
> the whole series again and annoy all the people in Cc one more time
> ;-).

Thanks.  The only problem that I can see is the fact you're not
checking for req->src == req->dst.  If they're equal then you must
not map it twice.  Instead it should be mapped as DMA_BIDIRECTIONAL.

Cheers,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list