[PATCH 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi
linux at roeck-us.net
Fri Jun 12 05:18:15 PDT 2015
On 06/12/2015 04:26 AM, Stefan Wahren wrote:
> Hi Noralf,
> Am 09.06.2015 um 12:21 schrieb Noralf Trønnes:
>> This adds a new poweroff function to the watchdog driver for the
>> Raspberry Pi. Currently poweroff/halt results in a reboot.
>> +static void rpi_power_off(void)
>> + struct device_node *np =
>> + of_find_compatible_node(NULL, NULL, "brcm,raspberrypi-pm-wdt");
>> + struct platform_device *pdev = of_find_device_by_node(np);
>> + struct bcm2835_wdt *wdt = platform_get_drvdata(pdev);
>> + u32 val;
>> + val = readl_relaxed(wdt->base + PM_RSTS);
> do you think it's safe here to assume wdt could never be NULL?
If the call is made, the driver must be instantiated. We can therefore assume
that neither np, pdev, nor wdt is NULL. If one of those is NULL, it would be
a bug, which should not be ignored.
More information about the linux-arm-kernel