[PATCH 01/15] ARM: kill off set_irq_flags usage
Krzysztof Kozlowski
k.kozlowski at samsung.com
Fri Jun 12 02:30:16 PDT 2015
On 10.06.2015 03:26, Rob Herring wrote:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> Cc: Russell King <linux at arm.linux.org.uk>
> Cc: Sekhar Nori <nsekhar at ti.com>
> Cc: Kevin Hilman <khilman at deeprootsystems.com>
> Cc: Jason Cooper <jason at lakedaemon.net>
> Cc: Andrew Lunn <andrew at lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
> Cc: Gregory Clement <gregory.clement at free-electrons.com>
> Cc: Hans Ulli Kroll <ulli.kroll at googlemail.com>
> Cc: Shawn Guo <shawn.guo at linaro.org>
> Cc: Sascha Hauer <kernel at pengutronix.de>
> Cc: Imre Kaloz <kaloz at openwrt.org>
> Cc: Krzysztof Halasa <khalasa at piap.pl>
> Cc: Greg Ungerer <gerg at uclinux.org>
> Cc: Roland Stigge <stigge at antcom.de>
> Cc: Tony Lindgren <tony at atomide.com>
> Cc: Daniel Mack <daniel at zonque.org>
> Cc: Haojian Zhuang <haojian.zhuang at gmail.com>
> Cc: Robert Jarzmik <robert.jarzmik at free.fr>
> Cc: Simtec Linux Team <linux at simtec.co.uk>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> Cc: Wan ZongShun <mcuos.com at gmail.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-omap at vger.kernel.org
> Cc: linux-samsung-soc at vger.kernel.org
> ---
> arch/arm/common/it8152.c | 2 +-
> arch/arm/common/locomo.c | 2 +-
> arch/arm/common/sa1111.c | 4 ++--
> arch/arm/mach-davinci/cp_intc.c | 2 +-
> arch/arm/mach-dove/irq.c | 2 +-
> arch/arm/mach-ebsa110/core.c | 2 +-
> arch/arm/mach-footbridge/common.c | 2 +-
> arch/arm/mach-footbridge/isa-irq.c | 8 ++++----
> arch/arm/mach-gemini/gpio.c | 2 +-
> arch/arm/mach-gemini/irq.c | 2 +-
> arch/arm/mach-imx/3ds_debugboard.c | 2 +-
> arch/arm/mach-imx/mach-mx31ads.c | 2 +-
> arch/arm/mach-iop13xx/irq.c | 2 +-
> arch/arm/mach-iop32x/irq.c | 2 +-
> arch/arm/mach-iop33x/irq.c | 2 +-
> arch/arm/mach-ixp4xx/common.c | 2 +-
> arch/arm/mach-ks8695/irq.c | 2 +-
> arch/arm/mach-lpc32xx/irq.c | 2 +-
> arch/arm/mach-netx/generic.c | 2 +-
> arch/arm/mach-omap1/fpga.c | 2 +-
> arch/arm/mach-omap1/irq.c | 2 +-
> arch/arm/mach-pxa/balloon3.c | 2 +-
> arch/arm/mach-pxa/irq.c | 1 -
> arch/arm/mach-pxa/lpd270.c | 2 +-
> arch/arm/mach-pxa/pcm990-baseboard.c | 2 +-
> arch/arm/mach-pxa/pxa3xx.c | 2 +-
> arch/arm/mach-pxa/viper.c | 2 +-
> arch/arm/mach-pxa/zeus.c | 2 +-
> arch/arm/mach-rpc/ecard.c | 2 +-
> arch/arm/mach-rpc/irq.c | 16 ++++++++--------
> arch/arm/mach-s3c24xx/bast-irq.c | 2 +-
> arch/arm/mach-s3c64xx/common.c | 2 +-
> arch/arm/mach-sa1100/irq.c | 1 -
> arch/arm/mach-sa1100/neponset.c | 4 ++--
> arch/arm/mach-w90x900/irq.c | 2 +-
> 35 files changed, 45 insertions(+), 47 deletions(-)
For the s3c24xx and s3c64xx it looks fine:
Acked-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list