[PATCH 09/15] mfd: kill off set_irq_flags usage

Linus Walleij linus.walleij at linaro.org
Wed Jun 10 05:43:54 PDT 2015


On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring <robh at kernel.org> wrote:

> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> Cc: Samuel Ortiz <sameo at linux.intel.com>
> Cc: Lee Jones <lee.jones at linaro.org>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Milo Kim <milo.kim at ti.com>
> Cc: Kumar Gala <galak at codeaurora.org>
> Cc: Andy Gross <agross at codeaurora.org>
> Cc: David Brown <davidb at codeaurora.org>
> Cc: Tony Lindgren <tony at atomide.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: patches at opensource.wolfsonmicro.com
> Cc: linux-arm-msm at vger.kernel.org
> Cc: linux-soc at vger.kernel.org
> Cc: linux-omap at vger.kernel.org

Acked-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list