[PATCH 2/2] cpufreq: mediatek: Add MT8173 cpufreq driver

Pi-Cheng Chen pi-cheng.chen at linaro.org
Tue Jun 9 20:37:52 PDT 2015


On Tue, Jun 9, 2015 at 5:17 PM, Paul Bolle <pebolle at tiscali.nl> wrote:
> On Mon, 2015-06-08 at 20:29 +0800, Pi-Cheng Chen wrote:
>> --- /dev/null
>> +++ b/drivers/cpufreq/mt8173-cpufreq.c
>
>> +#include <linux/module.h>
>
> Weren't you going to drop this include?

Sorry I forget to merge that part of fix into this patch.
Will fix it.

>
>> +module_init(mt8173_cpufreq_driver_init);
>
> For built-in code this is equivalent to, speaking from memory:
>     device_initcall(mt8173_cpufreq_driver_init);
>
> Why don't you just use that directly?

Yes. Will do it.
Thanks for reviewing.

Best Regards,
Pi-Cheng

>
> Thanks,
>
>
> Paul Bolle
>



More information about the linux-arm-kernel mailing list