[PATCH v5 4/6] i2c: at91: add support for new alternative command mode

Wolfram Sang wsa at the-dreams.de
Tue Jun 9 15:19:37 PDT 2015


Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
> 
> No, please name it:
> 
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150610/cf6ea07d/attachment.sig>


More information about the linux-arm-kernel mailing list