[PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away

Mark Brown broonie at kernel.org
Tue Jun 9 03:10:05 PDT 2015


On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote:

> Admittedly this is an extreme example, but I do consider:

> 	init_data = of_get_regulator_init_data(<blah>);
> 	if (init_data)
>         	return -ENOMEM;

> ... neater than:

> 	config.init_data = of_get_regulator_init_data(<blah>);
> 	if (!config.init_data)
>         	return -ENOMEM;

Oh, I see.  I pretty much see things the other way for things where the
temporary has no other users.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150609/f9d5ce95/attachment.sig>


More information about the linux-arm-kernel mailing list