[PATCH 10/11] spi: add more debug prints in s3c64xx
broonie at kernel.org
Thu Jun 4 02:42:48 PDT 2015
On Thu, Jun 04, 2015 at 11:30:15AM +0200, Geert Uytterhoeven wrote:
> On Thu, Jun 4, 2015 at 11:16 AM, Mark Brown <broonie at kernel.org> wrote:
> >> --- a/drivers/spi/spi-s3c64xx.c
> >> +++ b/drivers/spi/spi-s3c64xx.c
> >> @@ -18,6 +18,7 @@
> >> #include <linux/interrupt.h>
> >> #include <linux/delay.h>
> >> #include <linux/clk.h>
> >> +#include <linux/clk-provider.h>
> > Whatever you're doing here this indicates that there's a very big
> > abstraction problem going on.
> I guess it's needed for __clk_get_name(), which can be avoided by using
> the "%pC" printf format specifier instead.
Right, or by adding an externally usable API - the point is that using
internal functions in a client driver is a big red flag.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: Digital signature
More information about the linux-arm-kernel