[PATCH 04/12] i2c: pxa: Add support for pxa910/988 & new configuration features
Vaibhav Hiremath
vaibhav.hiremath at linaro.org
Mon Jun 1 22:01:38 PDT 2015
On Monday 01 June 2015 05:43 AM, Wolfram Sang wrote:
> On 2015-05-28 22:03, Vaibhav Hiremath wrote:
>> From: "Jett.Zhou" <jtzhou at marvell.com>
>>
>> TWSI_ILCR & TWSI_IWCR registers are used to adjust clock rate
>> of standard & fast mode in pxa910/988; so this patch adds these two new
>> entries to "struct pxa_reg_layout" and "struct pxa_i2c" and also adds two
>> new DT properties to take configuration value for the same.
>
> Mapping registers 1:1 to DT is nearly always wrong. We have some generic
> bindings for SCL/SDA tweaking. Check
> Documentation/devicetree/bindings/i2c/i2c-designware.txt for them and if
> they match your needs. (Yes, they should be in a more generic place).
>
>
Thanks for your suggestion.
Let me check above documentation.
Thanks,
Vaibhav
More information about the linux-arm-kernel
mailing list