[PATCH] arm/mm: fix compiler warning in pmdp_invalidate() (in -next)
mgorman at suse.de
Fri Jan 30 02:06:20 PST 2015
On Thu, Jan 29, 2015 at 05:48:00PM +0000, Andre Przywara wrote:
> Commit ff61d185f4e7 ("mm: convert p[te|md]_mknonnuma and remaining
> page table manipulations") removed a check in
> mm/pgtable-generic.c:pmdp_invalidate(), which leaves the
> pmd_mknotpresent macro the only user of the entry variable.
> For ARM/LPAE we use a constant 0 without referencing the argument to
> mark this condition, so the entry variable is no longer used here:
> mm/pgtable-generic.c: In function 'pmdp_invalidate':
> mm/pgtable-generic.c:195:8: warning: unused variable 'entry' [-Wunused-variable]
> pmd_t entry = *pmdp;
> Replace the ARM macro implementation with a static inline function to
> get rid of this warning.
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
Patch looks fine to me but this is against a mmotm patch that is
included in mmotm. The commit ID is not going to last. This should be
sent to Andrew Morton with a note saying it's a fix to the mmotm patch
He'll then fold your fix into the original patch so that bisection works
correctly when merged to mainline. Do you mind doing that please?
More information about the linux-arm-kernel