[PATCH] mmc: moxart: fix probe logic

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Jan 29 09:01:04 PST 2015


On Thu, Jan 29, 2015 at 05:15:31PM +0100, Arnd Bergmann wrote:
> @@ -586,10 +586,10 @@ static int moxart_probe(struct platform_device *pdev)
>  		goto out;
>  	}
>  
> -	clk = of_clk_get(node, 0);
> -	if (IS_ERR(clk)) {
> +	host->clk = of_clk_get(node, 0);
> +	if (IS_ERR(host->clk)) {
>  		dev_err(dev, "of_clk_get failed\n");
> -		ret = PTR_ERR(clk);
> +		ret = PTR_ERR(host->clk);
>  		goto out;
>  	}
>  
...
> @@ -677,6 +679,8 @@ static int moxart_probe(struct platform_device *pdev)
>  	return 0;
>  
>  out:
> +	if (host->clk)
> +		clk_put(host->clk);

Are you sure?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list