[PATCH] crypto: atmel: remove bogus select
ludovic.desroches at atmel.com
Wed Jan 28 23:33:28 PST 2015
On Wed, Jan 28, 2015 at 09:09:16PM +0100, Arnd Bergmann wrote:
> The Atmel at91 crypto driver unconditionally selects AT_HDMAC,
> which results in a Kconfig warning if that driver is not enabled:
> warning: (CRYPTO_DEV_ATMEL_AES) selects AT_HDMAC which has unmet direct dependencies (DMADEVICES && ARCH_AT91)
> The crypty driver itself does not actually have a dependency
> on a particular dma engine, other than this being the one that
> is used in at91.
> Removing the 'select' gets rid of the warning, with no apparent
This driver doesn't work without DMA. I think it is the reason why the
select AT_HDMAC was used.
> We should probably enable AT_HDMAC in sama5_defconfig, because
> it no longers gets enabled implicitly.
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 2fb0fdfc87df..0c411c0aae99 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -348,7 +348,6 @@ config CRYPTO_DEV_ATMEL_AES
> select CRYPTO_AES
> select CRYPTO_ALGAPI
> select CRYPTO_BLKCIPHER
> - select AT_HDMAC
> Some Atmel processors have AES hw accelerator.
> Select this if you want to use the Atmel module for
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
More information about the linux-arm-kernel